GLSL code not saving changes?

bonemap

Hi,

I might be missing something with the GLSL editor. I have made modifications to the GLSL code using Isadora's built-in editor compiled the code - all working good - saved the patch, but when I quit and relaunch Isadora none of the code changes have been saved in the GLSL shader code. I am sure I have previously edited and saved GLSL code changes directly with Isadora's code editor, but perhaps I have missed a step in saving those changes to the GLSL text file? I have checked through the GLSL documentation and tutorial but did not find any additional steps needed for saving the code. There is the option to open the GLSL text file in a separate text editor, but that adds a lot of extra steps.

Regards,
bonemap

Skulpture

@bonemap

This is an interesting point actually and something I have (somehow) not checked. For now maybe it may be best copying and pasting the txt in a text file as a back-up. FYI; You can also name this file and drag and drop it back into the same folder so you can have multiple versions.

Michel

@bonemap

Yes it seems that if you use a installed glsl actor and change the code there it does not get saved. Please file a bug report for that. Best work around I can think of at the moment is copy the code from the installed one and paste it in a blank "GLSL shader" actor.

Best Michel

Skulpture

In some ways I wonder if this can be classed as a bug?

The code we download, use and edit is a modification (normally) of someone else's work (of course not stolen but shared under the CC Licence unless otherwise stated). So if we change that code it sort of makes sense that we must save it as a duplicate and re-import it into Isadora - what do you guys think?

bonemap

@Skulpture

I don't really see the connection between the functionality of the Isadora program and the license attributes of GLSL code. The Isadora editor should be able to create, edit, modify and save glsl code to the associated text file. The ability to create an original shader through the Isadora interface is an important function.

You are asking us to think about a moral and philosophical question. Code authors (i.e. Shadertoy contributors) offer their glsl shader in good faith with a Creative Commons license. The terms of 'attribution', 'non-commercial' and 'share-alike' require respect. An acknowledgement in association with any public display or redistribution in the form of a credit or mention in program notes, I feel, fulfills the terms of the license when in a not-for-profit setting. If we are making money out of someone else's glsl code then the Creative Commons license on many of the shaders is no longer applicable and a commercial agreement is required.

The shader code available through glsl sharing sites is already offered as a mash-up and that is the nature of a 'share-alike' attribute in the 'non-commercial' setting. The only ethical reason that the glsl can be appended to the Isadora software is that the end user makes the moral judgement to respect the intellectual property and release of rights made by the original authors even if it appears as though the code is being given away freely. The shift from 'all rights reserved' to 'some rights reserved' is exactly what Lawrence Lessig had in mind when developing the legal structure of Creative Commons back in 2002.

cheers

bonemap

Skulpture

@bonemap said:

@Skulpture
I don't really see the connection between the functionality of the Isadora program and the license attributes of GLSL code. The Isadora editor should be able to create, edit, modify and save glsl code to the associated text file. The ability to create an original shader through the Isadora interface is an important function.

I was thinking much simpler, I guess what I am trying to say is do (most) users want to edit in a destructive way (overwrite) or non-destructive and have a 'save as...' and re-import with a new name (this could be automated too). A little bit like how user actors work now.

You are asking us to think about a moral and philosophical question....

I wasn't on purpose. But interesting discussion never the less.

bonemap

@Skulpture

Yes - a 'save as' and 'save' option in the glsl editor would be brilliant!

The interest for me is in the ability to integrate live parameters into the glsl shader. That is a fantastic implementation, but requires Isadora specific code to be introduced. It seems odd that those additions can not be saved through the internal editor - suggesting it is a bug in the program. I am sure compiling the glsl code in the editor saved the changes in previous releases of Isadora

cheers,
bonemap

Michel

@bonemap

Yes I am sure as well that it was possible. Please submit a bug report? https://support.troikatronix.c...

Best Michel

bonemap

@Michel

Yes already have